Removes the DbContext specimen builder (#25)

* Removes the DbContext specimen builder

* Adds custom dbcontext constructor tests for sqlite customization

src/EntityFrameworkCore.AutoFixture.Tests/Common/Persistence/TestConfigurationOptions.cs

@@ -0,0 +1,7 @@
+namespace EntityFrameworkCore.AutoFixture.Tests.Common.Persistence
+{
+    public class TestConfigurationOptions
+    {
+        public string SomeValue { get; set; }
+    }
+}

src/EntityFrameworkCore.AutoFixture.Tests/Common/Persistence/TestCustomDbContext.cs

@@ -0,0 +1,34 @@
+using EntityFrameworkCore.AutoFixture.Tests.Common.Persistence.Configuration;
+using EntityFrameworkCore.AutoFixture.Tests.Common.Persistence.Entities;
+using Microsoft.EntityFrameworkCore;
+
+namespace EntityFrameworkCore.AutoFixture.Tests.Common.Persistence
+{
+    public class TestCustomDbContext : DbContext
+    {
+        public TestCustomDbContext()
+        {
+        }
+
+        public TestCustomDbContext(
+            DbContextOptions<TestCustomDbContext> options,
+            ConfigurationOptions configurationOptions)
+            : base(options)
+        {
+            this.ConfigurationOptions = configurationOptions;
+        }
+
+        public ConfigurationOptions ConfigurationOptions { get; }
+
+        public DbSet<Customer> Customers { get; set; }
+        public DbSet<Item> Items { get; set; }
+        public DbSet<Order> Orders { get; set; }
+
+        protected override void OnModelCreating(ModelBuilder modelBuilder)
+        {
+            modelBuilder.ApplyConfiguration(new CustomerConfiguration());
+            modelBuilder.ApplyConfiguration(new ItemConfiguration());
+            modelBuilder.ApplyConfiguration(new OrderConfiguration());
+        }
+    }
+}

src/EntityFrameworkCore.AutoFixture.Tests/Common/Persistence/TestDbContext.cs

@@ -21,10 +21,14 @@ public TestDbContext(DbContextOptions<TestDbContext> options)
 
         protected override void OnModelCreating(ModelBuilder modelBuilder)
         {
-            base.OnModelCreating(modelBuilder);
             modelBuilder.ApplyConfiguration(new CustomerConfiguration());
             modelBuilder.ApplyConfiguration(new ItemConfiguration());
             modelBuilder.ApplyConfiguration(new OrderConfiguration());
         }
     }
+
+    public class ConfigurationOptions
+    {
+        public string SomeValue { get; set; }
+    }
 }

src/EntityFrameworkCore.AutoFixture.Tests/Core/DbContextCustomizationTests.cs

@@ -9,18 +9,6 @@ namespace EntityFrameworkCore.AutoFixture.Tests.Core
 {
     public class DbContextCustomizationTests
     {
-        [Theory]
-        [AutoData]
-        public void Customize_ShouldAddContextBuilderToFixture(
-            Fixture fixture,
-            DbContextCustomization customization)
-        {
-            fixture.Customize(customization);
-
-            fixture.Customizations.Should()
-                .ContainSingle(x => x.GetType() == typeof(DbContextSpecimenBuilder));
-        }
-
         [Theory]
         [AutoData]
         public void Customize_ShouldAddOptionsBuilderToFixture(

src/EntityFrameworkCore.AutoFixture.Tests/InMemory/InMemoryCustomizationTests.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Threading.Tasks;
 using AutoFixture;
+using AutoFixture.Kernel;
 using AutoFixture.Xunit2;
 using EntityFrameworkCore.AutoFixture.InMemory;
 using EntityFrameworkCore.AutoFixture.Tests.Common.Attributes;
@@ -15,9 +16,17 @@ public class InMemoryCustomizationTests
     {
         [Theory]
         [AutoData]
-        public void SaveChanges_ShouldCreateCustomerRecord(Fixture fixture, InMemoryContextCustomization customization)
+        public void SaveChanges_ShouldCreateCustomerRecord(
+            InMemoryContextCustomization customization,
+            Fixture fixture)
         {
-            fixture.Customize(customization);
+            fixture.Customize(
+                    new CompositeCustomization(
+                        customization,
+                        new ConstructorCustomization(
+                            typeof(TestDbContext),
+                            new GreedyConstructorQuery())));
+
             using var context = fixture.Create<TestDbContext>();
             context.Database.EnsureCreated();
 
@@ -29,7 +38,7 @@ public void SaveChanges_ShouldCreateCustomerRecord(Fixture fixture, InMemoryCont
 
         [Theory]
         [AutoDomainDataWithInMemoryContext]
-        public async Task SaveChangesAsync_ShouldCreateCustomerRecord(TestDbContext context)
+        public async Task SaveChangesAsync_ShouldCreateCustomerRecord([Greedy] TestDbContext context)
         {
             using (context)
             {
@@ -44,11 +53,13 @@ public async Task SaveChangesAsync_ShouldCreateCustomerRecord(TestDbContext cont
 
         [Theory]
         [AutoData]
-        public void Customize_ShouldAddOptionsBuilderToFixture(Fixture fixture, InMemoryContextCustomization customization)
+        public void Customize_ShouldAddOptionsBuilderToFixture(InMemoryContextCustomization customization,
+            Fixture fixture)
         {
             fixture.Customize(customization);
 
-            fixture.Customizations.Should().ContainSingle(x => x.GetType() == typeof(InMemoryOptionsSpecimenBuilder));
+            fixture.Customizations.Should()
+                .ContainSingle(x => x.GetType() == typeof(InMemoryOptionsSpecimenBuilder));
         }
 
         [Theory]
@@ -59,5 +70,21 @@ public void Customize_ForNullFixture_ShouldThrow(InMemoryContextCustomization cu
 
             act.Should().ThrowExactly<ArgumentNullException>();
         }
+
+        [Theory]
+        [AutoDomainDataWithInMemoryContext]
+        public void Customize_ForCustomDbContext_ShouldReturnContextInstance([Greedy] TestCustomDbContext context)
+        {
+            context.Should().NotBeNull()
+                .And.BeOfType<TestCustomDbContext>();
+        }
+
+        [Theory]
+        [AutoDomainDataWithInMemoryContext]
+        public void Customize_ForCustomDbContext_ProvideValueForOtherParameters(
+            [Greedy] TestCustomDbContext context)
+        {
+            context.ConfigurationOptions.Should().NotBeNull();
+        }
     }
 }

src/EntityFrameworkCore.AutoFixture.Tests/Sqlite/SqliteCustomizationTests.cs

@@ -15,7 +15,10 @@ public class SqliteCustomizationTests
     {
         [Theory]
         [AutoDomainDataWithSqliteContext]
-        public void Customize_ShouldProvideSqliteContext([Frozen] SqliteConnection connection, TestDbContext context, Item item, Customer customer)
+        public void Customize_ShouldProvideSqliteContext(
+            [Frozen] SqliteConnection connection,
+            [Greedy] TestDbContext context,
+            Item item, Customer customer)
         {
             using (connection)
             using (context)
@@ -60,5 +63,21 @@ public void Customize_ForNullFixture_ShouldThrow(SqliteContextCustomization cust
 
             act.Should().ThrowExactly<ArgumentNullException>();
         }
+
+        [Theory]
+        [AutoDomainDataWithSqliteContext]
+        public void Customize_ForCustomDbContext_ShouldReturnContextInstance([Greedy] TestCustomDbContext context)
+        {
+            context.Should().NotBeNull()
+                .And.BeOfType<TestCustomDbContext>();
+        }
+
+        [Theory]
+        [AutoDomainDataWithSqliteContext]
+        public void Customize_ForCustomDbContext_ProvideValueForOtherParameters(
+            [Greedy] TestCustomDbContext context)
+        {
+            context.ConfigurationOptions.Should().NotBeNull();
+        }
     }
 }

src/EntityFrameworkCore.AutoFixture/Core/DbContextCustomization.cs

@@ -12,7 +12,6 @@ public virtual void Customize(IFixture fixture)
                 throw new ArgumentNullException(nameof(fixture));
             }
 
-            fixture.Customizations.Add(new DbContextSpecimenBuilder());
             fixture.Customizations.Add(new DbContextOptionsSpecimenBuilder());
         }
     }