myhoard: On basebackup command failure raise XtraBackupError #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Static checks fail, otherwise lgtm |
willrouesnel-aivenio
force-pushed
the
willrouesnel/ch19530/suppress-backup-failures-from-reporting-as
branch
from
49b5658
to
a61e52c
Compare
|
Apparently pylint version has changed and some unrelated changes are required to make that pass |
Noticed that. I think this needs to brought inline with the config we have pghoard. |
willrouesnel-aivenio
force-pushed
the
willrouesnel/ch19530/suppress-backup-failures-from-reporting-as
branch
4 times, most recently
from
65964d0
to
6297942
Compare
willrouesnel-aivenio
force-pushed
the
willrouesnel/ch19530/suppress-backup-failures-from-reporting-as
branch
2 times, most recently
from
f319c51
to
aa1eaf5
Compare
rikonen
reviewed
Sep 25, 2020
rikonen
reviewed
Sep 25, 2020
rikonen
reviewed
Sep 25, 2020
rikonen
reviewed
Sep 25, 2020
willrouesnel-aivenio
force-pushed
the
willrouesnel/ch19530/suppress-backup-failures-from-reporting-as
branch
3 times, most recently
from
49336a1
to
d73ddad
Compare
Identity failures of the backup process command as a specific exception type rather then just Exception, then filter them out of the normal unexpected_exception dispatch. This is because they can't raise any possible error which can be dealt with by looking at Sentry, and don't include any useful error data.
willrouesnel-aivenio
force-pushed
the
willrouesnel/ch19530/suppress-backup-failures-from-reporting-as
branch
from
d73ddad
to
f5a93cb
Compare
|
Everything here is rebased on the other fix, so this should be good to go now. |
rikonen
approved these changes
Sep 25, 2020
rikonen
deleted the
willrouesnel/ch19530/suppress-backup-failures-from-reporting-as
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identity failures of the backup process command as a specific exception type rather then just Exception, then filter them out of the normal unexpected_exception dispatch. This is because they can't raise any possible error which can be dealt with by looking at Sentry, and don't include any useful error data.