timestamps: fix second calculation between datetime objects #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved ClusterMonitor ands its dependencies as-is to a new file.
Moved WebServer and its dependencies as-is to a new file.
Refactored some code to make it easier to test it and simplified cases where we use optional values from dicts, including removing code that could was never executed.
timedelta.seconds only returns the seconds-part of the delta and doesn't consider days (or microseconds). Use the total_seconds() function instead which takes all parts of the delta in account. This fixes cases where we had > 1 day replication lag and could have incorrectly returned low results. Usually this was probably not an issue as replication lag rarely grows beyond a day, and even if it does the window where previous day's time matches current time is short. NOTE: we can't use total_seconds() directly from timedelta objects as it's not available on Python 2.6. Implement a compat function in common.py.
saaros
force-pushed
the
refactoring-and-fixes
branch
2 times, most recently
from
57628bc
to
2c7b74d
Compare
saaros
force-pushed
the
refactoring-and-fixes
branch
from
2c7b74d
to
379ff31
Compare
melor
added a commit
that referenced
this pull request
Aug 25, 2015
timestamps: fix second calculation between datetime objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus refactoring and a few minor fixes.