Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being a performance freak I was curious why you call NetVars::GetOffset continually at runtime as opposed to finding needed offsets during initialization then referring to those later.
I realized that GetOffset could probably be modified to cache values to get a similar performance benefit without having to rewrite much existing code.
Here are some comparisons of cached vs uncached. Each time value is for running
NetVars::GetOffset("CBasePlayer", "m_vecPunchAngle")
5x in a row. The first result being slower is due to construction of the static unordered_map plus having to realloc. (could probably add a reserve() in there to optimize)Otherwise it seems to have resulted in about a 10x speedup over the original, which is pretty decent. It might be slightly less than 10x in practice since this was just one offset in the cache, but still a pretty good improvement.