Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal function usage from MarkdownRenderer #88

Merged
merged 10 commits into from Apr 9, 2023

Conversation

ajalt
Copy link
Owner

@ajalt ajalt commented Feb 5, 2023

This was an exercise in Mordant's public API. Rather than working with Lines directly, the renderer now uses linear layouts and invoked styles. This didn't end up needing much change to the renderer, and I actually found it easier to reason about.

Major changes:

  • Style resets
  • A separate implementation of VerticalLayout rather than using Table. Not strictly necessary, but it was easy and should be a little faster.

@ajalt ajalt merged commit a961c56 into master Apr 9, 2023
3 checks passed
@ajalt ajalt deleted the split-out-markdown branch April 9, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant