New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose all methods using async/await API for iOS > 13 and macOS > 10.15 #137
Conversation
This is a good add for foward looking. I think the CI is failing because of the version. Let me check if i can update it. |
@ajamaica Glad you like it ! Yeah, it’s very likely due to the version! Keep me posted |
I fix the CI. If you can rebase it I can test it again and merge it. I had to move to genesys go devnet to fix the ci. |
+ Default implementation
c7c4a0a
to
8b63dcb
Compare
@ajamaica I rebased but unfortunately some tests are failing, even in master branch :
|
Solana wipes history from time to time. There is no full blockchain history. Let me fix the tests to be more permanent using the current block. |
I fixed the tests |
This simple PR introduce an async/await version of all the callback based methods.
All new async endpoints exist alongside the callback based ones, it therefore doesn't introduce any breaking change, just a larger choice.
Tests have also been simplified, which is a double benefit as it also tests the proxying logic (async endpoints are just wrappers around existing callback based methods).