Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all methods using async/await API for iOS > 13 and macOS > 10.15 #137

Closed
wants to merge 16 commits into from

Conversation

hmazelier
Copy link

This simple PR introduce an async/await version of all the callback based methods.
All new async endpoints exist alongside the callback based ones, it therefore doesn't introduce any breaking change, just a larger choice.
Tests have also been simplified, which is a double benefit as it also tests the proxying logic (async endpoints are just wrappers around existing callback based methods).

@ajamaica
Copy link
Contributor

This is a good add for foward looking. I think the CI is failing because of the version. Let me check if i can update it.

@hmazelier
Copy link
Author

@ajamaica Glad you like it ! Yeah, it’s very likely due to the version! Keep me posted

@ajamaica
Copy link
Contributor

I fix the CI. If you can rebase it I can test it again and merge it. I had to move to genesys go devnet to fix the ci.

@hmazelier
Copy link
Author

@ajamaica I rebased but unfortunately some tests are failing, even in master branch :

  • testGetBlockTime -> throws :
invalidResponse(Solana.ResponseError(code: Optional(-32001), message: Optional("Block 109479081 cleaned up, does not exist on node. First available block: 109650303"), data: nil))
  • testGetConfirmedBlocks -> 0 blocks instead of 2
  • testGetConfirmedTransaction -> throws Solana.RPCError.unknownResponse

@ajamaica
Copy link
Contributor

Solana wipes history from time to time. There is no full blockchain history. Let me fix the tests to be more permanent using the current block.

@ajamaica
Copy link
Contributor

I fixed the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants