do not release mouse if command doesn't modify the selection

ajaxorg · Dec 26, 2017 · 8102837 · 8102837
1 parent a11bb67
commit 8102837
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/lib/ace/mouse/mouse_handler.js b/lib/ace/mouse/mouse_handler.js
@@ -161,7 +161,7 @@ var MouseHandler = function(editor) {
         };
 
         var onCaptureEnd = function(e) {
-            editor.commands.off("exec", onOperationEnd);
+            editor.off("beforeEndOperation", onOperationEnd);
             clearInterval(timerId);
             onCaptureInterval();
             self[self.state + "End"] && self[self.state + "End"](e);
@@ -187,11 +187,14 @@ var MouseHandler = function(editor) {
         var onOperationEnd = function(e) {
             // some touchpads fire mouseup event after a slight delay, 
             // which can cause problems if user presses a keyboard shortcut quickly
-            if (editor.curOp.command.name)
+            if (editor.curOp.command.name && editor.curOp.selectionChanged) {
+                self[self.state + "End"] && self[self.state + "End"]();
+                self.state = "";
                 self.releaseMouse();
+            }
         };
 
-        editor.commands.on("exec", onOperationEnd);
+        editor.on("beforeEndOperation", onOperationEnd);
 
         self.$onCaptureMouseMove = onMouseMove;
         self.releaseMouse = event.capture(this.editor.container, onMouseMove, onCaptureEnd);