Skip to content

Commit

Permalink
Automate Generation of d.ts for Ace Editor Modes (#5518)
Browse files Browse the repository at this point in the history
* add automatic modes declaration generator

* fix: wrong export in ruby mode

* re-generate ace-modes

* ci check

---------

Co-authored-by: nightwing <amirjanyan@gmail.com>
  • Loading branch information
mkslanc and nightwing committed Apr 5, 2024
1 parent bb8256d commit e59ae67
Show file tree
Hide file tree
Showing 5 changed files with 1,196 additions and 628 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
node-version: ${{ matrix.node-version }}
- run: npm i
- run: npm run cover
# run linter
- run: |
set -x;
git status;
Expand All @@ -50,9 +51,11 @@ jobs:
node node_modules/eslint/bin/eslint $jsChanges;
fi
fi
# - run: npm run lint
# check types
- run: npm run update-types
- run: node_modules/.bin/tsc --noImplicitAny --strict --noUnusedLocals --noImplicitReturns --noUnusedParameters --noImplicitThis ace.d.ts
- run: npm run typecheck
- run: git diff --exit-code ./ace-modes.d.ts ./ace.d.ts
- uses: codecov/codecov-action@v3
with:
token: d8edca4b-8e97-41e5-b54e-34c7cf3b2d47
Expand Down

0 comments on commit e59ae67

Please sign in to comment.