Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged undos don't decrement dirtyCounter correctly #1757

Closed
Chonne opened this issue Jan 10, 2014 · 0 comments
Closed

Merged undos don't decrement dirtyCounter correctly #1757

Chonne opened this issue Jan 10, 2014 · 0 comments

Comments

@Chonne
Copy link

Chonne commented Jan 10, 2014

This is following the implementation of undo merging.

When the mergeUndoDeltas option is set to true, if a user types a few characters at once then executes the undo() command, the UndoManager's dirtyCounter variable is only decremented once instead of being decremented by the number of merged undos. Note that this will probably happen for any merged undo commands.

This makes it difficult to check if a document is clean or, rendering the UndoManager's isClean() method useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant