Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ace always takes focus #320

Closed
Gozala opened this issue Jun 30, 2011 · 1 comment
Closed

Ace always takes focus #320

Gozala opened this issue Jun 30, 2011 · 1 comment

Comments

@Gozala
Copy link
Contributor

Gozala commented Jun 30, 2011

I have been trying for a long time to set a keybinding to jump to cli, no matter how much I tried it never worked. Finally I discovered that issue was not in CLI component but in Editor:

https://github.com/ajaxorg/ace/blob/master/lib/ace/keyboard/textinput.js#L73-75

What happens is that keyboard handler gives a focus to CLI but then selection is set back to hidden text area. This should not be a case and I guess only proper solution here is to verify that text area still has a focus before selecting.
Gozala added a commit to Gozala/ace that referenced this issue Jun 30, 2011
@Gozala
Fix for greedy focus issue ajaxorg#320
4803f92
fjakobs added a commit that referenced this issue Jun 30, 2011
@fjakobs
Merge pull request #321 from Gozala/bugs/focus.greedy-320
3cb6ded 
Fix for greedy focus issue #320
@fjakobs
Copy link
Contributor

fjakobs commented Jul 23, 2011

should be fixed by now

@fjakobs fjakobs closed this as completed Jul 23, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gozala @fjakobs