fix: Improve ARIA labelling fold controls #5205
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5205 +/- ##
==========================================
+ Coverage 87.19% 87.20% +0.01%
==========================================
Files 565 565
Lines 45121 45161 +40
Branches 6910 6914 +4
==========================================
+ Hits 39342 39382 +40
Misses 5779 5779
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
demo/i18n.html
Outdated
| "Unfold rows $0 to $1": "", | ||
| "Code folding, rows $0 through $1": "", | ||
| "Code folding, row $0": "", | ||
| "Unfold code": "", | ||
| "Fold at row $0": "", |
There was a problem hiding this comment.
if someone was using the old translation keys, what is going to happen? can we at least show a warning? can we support both by deprecating the old one?
There was a problem hiding this comment.
added a warning when a Ace tries to replace a string using the nls function but can't find a translation in the provided messages.
There was a problem hiding this comment.
Does this mean this is a breaking change? If so, can we avoid it or is it intentional?
Description of changes: For a11y compliance, buttons that show/hide content should have an
aria-expandedstate. This adds that state and changes the aria label accordingly.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.