Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent scrolling to the top #3227

Closed
wants to merge 1 commit into from
Closed

prevent scrolling to the top #3227

wants to merge 1 commit into from

Conversation

otopsy
Copy link

@otopsy otopsy commented Feb 27, 2017

prevent windows scrolling to the document's top, when ace is at the bottom of the page ( long page )

prevent windows scrolling to the document's top, when ace is at the bottom of the page ( long page )
@otopsy
Copy link
Author

otopsy commented Feb 27, 2017

👍

@nightwing
Copy link
Member

Could you provide a testcase showing what does this fix?
This change causes the page to scroll when editor is focused on https://rawgit.com/otopsy/ace/e33fd8cd16fc38526cf6abb6dbd8ec20dd81a9bc/demo/scrollable-page.html
The version of that page from master doesn't scroll
https://rawgit.com/ajaxorg/ace/v1.2.6/demo/scrollable-page.html

@DZGoldman
Copy link

👍

1 similar comment
@dginev
Copy link

dginev commented Mar 16, 2017

👍

@nightwing
Copy link
Member

the issue should be fixed by #3279

@nightwing nightwing closed this Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants