Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toJSON method #3992

Closed
wants to merge 2 commits into from
Closed

Add toJSON method #3992

wants to merge 2 commits into from

Conversation

vanillajonathan
Copy link
Contributor

Adds a toJSON method to facilitate serialization of the the EditSession object into JSON through the JSON.stringify function.

Related to issue #1452

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Adds a toJSON method to facilitate serialization of the the EditSession object into JSON through the JSON.stringify function.
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #3992 into master will decrease coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3992      +/-   ##
==========================================
- Coverage   69.53%   69.52%   -0.01%     
==========================================
  Files         517      517              
  Lines       50205    50209       +4     
  Branches     9473     9473              
==========================================
+ Hits        34908    34909       +1     
- Misses      15297    15300       +3     
Impacted Files Coverage Δ
lib/ace/edit_session.js 84.91% <25.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d893a99...1dca181. Read the comment docs.

@vanillajonathan
Copy link
Contributor Author

@akoreman This got closed out of nowhere without any comment. Could this be merged?

@akoreman
Copy link
Contributor

The reason the PR got closed is that the branch (vanillajonathan:patch-1) within your fork of the repo got closed.

@vanillajonathan
Copy link
Contributor Author

Oh my bad, I created a new PR at #5326.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants