add json5 mode #4116
Merged
add json5 mode #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lennartcl
reviewed
Nov 21, 2019
| var startRules = [ | ||
| { | ||
| token : "variable", | ||
| regex : /(?<=[{\s]|^)[a-zA-Z$_\u00a1-\uffff][\w$\u00a1-\uffff]*\s*(?=:)/ |
There was a problem hiding this comment.
Test fails due to use of a lookbehind assertion
error Parsing error: Invalid regular expression: /(?<=[{\s]|^)[a-zA-Z$_\u00a1-\uffff][\w$\u00a1-\uffff]\s(?=:)/: Invalid group
There was a problem hiding this comment.
Thanks! I had forgotten that lookbehind is now supported in chrome.
There was a problem hiding this comment.
Yeah, that's pretty wonderful, but hard to support in other browsers :(
Codecov Report
@@ Coverage Diff @@
## master #4116 +/- ##
=========================================
+ Coverage 70.49% 70.5% +0.01%
=========================================
Files 521 523 +2
Lines 51115 51148 +33
Branches 9622 9622
=========================================
+ Hits 36031 36064 +33
Misses 15084 15084
Continue to review full report at Codecov.
|
lennartcl
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4096