Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Robot Framework syntax highlighting #4614

Merged
merged 6 commits into from
Jun 27, 2022

Conversation

SullyJHF
Copy link
Contributor

Issue #, if available:
#4489
Description of changes:
Add Robot Framework syntax highlighting.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nightwing
Copy link
Member

Looks like tests are failing because of using lookbehind in a regex. If you are not planning to support safari https://caniuse.com/?search=Lookbehind, i can modify the test runner to allow this failure on old versions of node and merge this pull request.

@SullyJHF
Copy link
Contributor Author

I think I've managed to remove the lookbehinds in the regexes, and the functionality is the same, so no worries on that one!

However, I'm now trying to add some snippets to this, but for some reason they aren't autocompleting in the kitchen sink demo, I've tested the python ones and they are completing correctly, but for some reason the robot framework ones aren't. Could you please look at the latest commit and advise as to what to do here?

@SullyJHF
Copy link
Contributor Author

Can you provide any assistance with this please?

@nightwing
Copy link
Member

Sorry i have missed this, the snippets in your commit don't work because they are indented with spaces instead of tabs.

@SullyJHF
Copy link
Contributor Author

SullyJHF commented May 5, 2022

Thanks for the help, I've changed the indentation to tabs and now the snippets behave as expected! Also fixed an error where some keywords were getting highlighted in the middle of words. I think this is good to go for merging now!

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #4614 (843c017) into master (a1ae7e5) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4614      +/-   ##
==========================================
+ Coverage   71.01%   71.19%   +0.18%     
==========================================
  Files         546      555       +9     
  Lines       55303    55597     +294     
  Branches    10376    10398      +22     
==========================================
+ Hits        39272    39581     +309     
+ Misses      16031    16016      -15     
Flag Coverage Δ
unittests 71.19% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ace/mode/robot.js 100.00% <100.00%> (ø)
lib/ace/mode/robot_highlight_rules.js 100.00% <100.00%> (ø)
lib/ace/ext/language_tools.js 69.91% <0.00%> (-2.99%) ⬇️
lib/ace/tokenizer.js 95.12% <0.00%> (-0.45%) ⬇️
lib/ace/ext/beautify.js 96.31% <0.00%> (-0.30%) ⬇️
lib/ace/mode/csound_orchestra_highlight_rules.js 97.61% <0.00%> (ø)
lib/ace/mode/partiql_highlight_rules.js 100.00% <0.00%> (ø)
lib/ace/mode/partiql.js 75.86% <0.00%> (ø)
lib/ace/ext/hardwrap_test.js 98.46% <0.00%> (ø)
lib/ace/mode/sac_highlight_rules.js 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ae7e5...843c017. Read the comment docs.

@andrewnester andrewnester merged commit 773c0c5 into ajaxorg:master Jun 27, 2022
@SullyJHF SullyJHF deleted the robot-lang branch June 27, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants