fix: Made commas be tokenized as punctuation operator instead of text in JSON #4703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4703 +/- ##
=======================================
Coverage 71.19% 71.19%
=======================================
Files 553 553
Lines 55598 55598
Branches 10392 10392
=======================================
+ Hits 39584 39585 +1
+ Misses 16014 16013 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nightwing
approved these changes
May 16, 2022
jeroenpost86
pushed a commit
to jeroenpost86/ace
that referenced
this pull request
May 19, 2022
* 'master' of https://github.com/ajaxorg/ace: fix: Made commas be tokenized as punctuation operator instead of text in JSON (ajaxorg#4703) fix: Multiple Partiql and Amazon Ion textual notation fixes (ajaxorg#4686) fix: Updated PHP mode to support PHP8.1 syntax (ajaxorg#4696) release v1.5.0 chore: use npm changelog in release script (ajaxorg#4698) feat: Added ability to configure certain format options for beautify extension fix: Render bidirectional unicode characters as control characters (ajaxorg#4693)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #4701
Description of changes:
Changed JSON parsing to tokenise commas as punctuation operator. It also fixes the way beatify works as reported in mentioned issue.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.