Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing options to EditorOptions #5003

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

dodgex
Copy link
Contributor

@dodgex dodgex commented Nov 24, 2022

While using ace in a small project, i realized that the options for ace/language_tool are missing in EditorOptions.

I tried to determine the types for the options in a best effort according to thier usage in
https://github.com/ajaxorg/ace/blob/v1.13.1/src/ext/language_tools.js#L152


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 86.11% // Head: 86.11% // No change to project coverage 👍

Coverage data is based on head (0774ec5) compared to base (fa64f84).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5003   +/-   ##
=======================================
  Coverage   86.11%   86.11%           
=======================================
  Files         546      546           
  Lines       41600    41600           
  Branches     6553     6553           
=======================================
  Hits        35822    35822           
  Misses       5778     5778           
Flag Coverage Δ
unittests 86.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrewnester andrewnester merged commit 451b63f into ajaxorg:master Nov 30, 2022
@andrewnester
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants