Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove will-change as it causes animations on chrome to hang #5094

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

nightwing
Copy link
Member

also adds an option to kitchen-sink to add dialog reproducing the issue. fixes #5074

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (469ea5d) 86.60% compared to head (4fd434a) 86.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5094   +/-   ##
=======================================
  Coverage   86.60%   86.60%           
=======================================
  Files         555      555           
  Lines       42931    42931           
  Branches     6697     6697           
=======================================
  Hits        37181    37181           
  Misses       5750     5750           
Flag Coverage Δ
unittests 86.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/css/editor.css.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nightwing nightwing mentioned this pull request Mar 19, 2023
@nightwing nightwing merged commit a2e89b9 into master Mar 21, 2023
@nightwing nightwing deleted the remove-will-change branch March 21, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance issue when using CSS animations
2 participants