Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #5162

Merged
merged 3 commits into from
May 12, 2023
Merged

Small fixes #5162

merged 3 commits into from
May 12, 2023

Conversation

nightwing
Copy link
Member

  • fix ace-linters in demo
  • use spacer token for alignment instead of making meta token itself large
  • do not use getValue in placeholder

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (2bb7fa0) 86.93% compared to head (9373ddf) 86.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5162      +/-   ##
==========================================
+ Coverage   86.93%   86.94%   +0.01%     
==========================================
  Files         561      561              
  Lines       44935    44965      +30     
  Branches     6909     6914       +5     
==========================================
+ Hits        39066    39097      +31     
+ Misses       5869     5868       -1     
Flag Coverage Δ
unittests 86.94% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/autocomplete/popup.js 85.27% <100.00%> (+0.05%) ⬆️
src/autocomplete_test.js 99.35% <100.00%> (+0.07%) ⬆️
src/editor.js 80.57% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nightwing nightwing merged commit 64c7758 into master May 12, 2023
3 checks passed
@nightwing nightwing deleted the small-fixes branch May 12, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants