Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announce doc-tooltips to assistive technology #5198

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

oykuyilmaz
Copy link
Contributor

@oykuyilmaz oykuyilmaz commented Jun 8, 2023

Issue #, if available:

  • N/A

Description of changes:
Doc-tooltips attached to autocomplete popover are now announced as more content.

Screenshot 2023-06-08 at 14 39 57

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@oykuyilmaz oykuyilmaz changed the title bug(autocomplete) announces doc-tooltip to assistive tech Announce doc-tooltips to assistive technology Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cd55932) 87.13% compared to head (18be0f4) 87.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5198   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files         564      564           
  Lines       45031    45034    +3     
  Branches     6908     6908           
=======================================
+ Hits        39236    39239    +3     
  Misses       5795     5795           
Flag Coverage Δ
unittests 87.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/autocomplete.js 80.20% <100.00%> (+0.08%) ⬆️
src/autocomplete/popup.js 85.32% <100.00%> (+0.05%) ⬆️
src/autocomplete_test.js 99.42% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oykuyilmaz oykuyilmaz merged commit 0732b1b into ajaxorg:master Jun 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants