Generate esm-resolver.d.ts to provide intellisense #5213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5213 +/- ##
=======================================
Coverage 87.22% 87.22%
=======================================
Files 565 565
Lines 45251 45251
Branches 6927 6927
=======================================
Hits 39469 39469
Misses 5782 5782
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nightwing
reviewed
Jun 22, 2023
tool/esm_resolver_generator.js
Outdated
| @@ -38,4 +41,8 @@ function getModuleNames() { | |||
| return paths; | |||
| } | |||
|
|
|||
| function generateDeclaration() { | |||
There was a problem hiding this comment.
On top level this function names says this is doing something general, but in fact it is generating a very specific declaration, so i'd suggest to move this string inline, where it is used. Also can you use a relative path? and also update pathModules above, which is used for ace-builds .
nightwing
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #5206
Description of changes:
This auto-generated declaration should enable Intellisense for different IDE's:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.