Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion to move Vim mode into ace #574

Closed
wants to merge 4 commits into from
Closed

Conversation

nightwing
Copy link
Member

Hi,

it seems to me that moving vim mode into ace, will make it easier to develop and less hacky
it will also benefit ace by making it's keybinding mechanism more general

here i moved vim keybindings, except cli, into ace and made more modular
so that one can simply use editor.setKeyboardHandler as with other handlers

also making vim a handler itself not depending on stateHandler, would make things more clear.( though there can be some subtleties)

@fjakobs
Copy link
Contributor

fjakobs commented Dec 14, 2011

That is cool!

@sergi can you take a look at this? We would have to change the license of these files but that should not be a problem.

@fjakobs
Copy link
Contributor

fjakobs commented Dec 16, 2011

We still have to do some due diligence with the license change of the vim mode code. I would suggest moving this into a feature branch until this is resolved.

Please note that any build containing the vim mode right now would be GPL licensed.

@fjakobs
Copy link
Contributor

fjakobs commented Dec 16, 2011

I have it here: https://github.com/ajaxorg/ace/tree/vim

I would like to keep rebasing this branch to master instead of merging. Would that be ok for you?

@fjakobs fjakobs closed this Dec 16, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants