suggestion to move Vim mode into ace #574
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
it seems to me that moving vim mode into ace, will make it easier to develop and less hacky
it will also benefit ace by making it's keybinding mechanism more general
here i moved vim keybindings, except cli, into ace and made more modular
so that one can simply use editor.setKeyboardHandler as with other handlers
also making vim a handler itself not depending on stateHandler, would make things more clear.( though there can be some subtleties)