Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme update #4

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Conversation

emem365
Copy link
Contributor

@emem365 emem365 commented Aug 25, 2020

Updating the ReadMe.
Also solves #3

@emem365 emem365 mentioned this pull request Aug 25, 2020
@ajay-prabhakar
Copy link
Owner

@emem365 thanks for your valuable contribution 🎉

just some quick reviews

  • Remove kotlin badge as most will contain only flutter
  • Add some badge like representing designs

Capture

  • In the above picture packages we are using is mixed with table please fix that
  • Use only one term for now use packages in use

Capture

  • Please give a new line after fear emoji
  • And Please add some descriptions for each designs

@emem365
Copy link
Contributor Author

emem365 commented Aug 25, 2020

  • Remove kotlin badge as most will contain only flutter

Done

  • Add some badge like representing designs

About this. Could you suggest something you had in mind? shields.io uses icons from simple-icons. Maybe have a look. We can add any text we like.

  • In the above picture packages we are using is mixed with table please fix that
  • Use only one term for now use packages in use
  • Please give a new line after fear emoji

These are done as well

  • And Please add some descriptions for each designs

For this, tbh, I'll have to take a look through all your screens myself. and tbh the gifs and the screenshot make it pretty self explanatory, and pretty much dont need a description. Maybe we could add something later :)

@ajay-prabhakar
Copy link
Owner

I don't have anything in my mind currently,
for now, it is fine

Copy link
Owner

@ajay-prabhakar ajay-prabhakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking forward to your contributions 😄

@ajay-prabhakar ajay-prabhakar merged commit 2c2ef6b into ajay-prabhakar:master Aug 26, 2020
@ajay-prabhakar
Copy link
Owner

May be can you add the contribution guidelines and license

@emem365
Copy link
Contributor Author

emem365 commented Aug 26, 2020

I am not sure if I can find time to write a Contributors guide right now. Maybe sometime later.

And for the license file:

  1. Go to your repo
  2. Add a file
  3. Name it LICENSE
    You will find that on the right side of text box for name of the file, there is an option to choose a license,
  4. Choose one which meets your needs(For most projects an Apache License is just fine)
  5. You'll need to put in your name and the year, and you're good to go

@ajay-prabhakar
Copy link
Owner

It fine,
I know how to add the lisence, I added the issue because someone who interested can contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants