Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow audio notification to work without popup notice #756

Closed
nerivera opened this issue May 22, 2021 · 0 comments · Fixed by #1091
Closed

Allow audio notification to work without popup notice #756

nerivera opened this issue May 22, 2021 · 0 comments · Fixed by #1091
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nerivera
Copy link

Currently, in order for the "Audio Notification On Skip" setting to work, the "Show Notice After A Segment Is Skipped" setting must be enabled. I would like for these two settings to be independent, as I want an audio notification to play when a segment is auto-skipped without the popup notice showing up.
@ajayyy ajayyy added good first issue Good for newcomers help wanted Extra attention is needed labels May 22, 2021
AronHK pushed a commit to AronHK/SponsorBlock that referenced this issue Dec 12, 2021
move audio notification to content.ts
9f9df94 
fixes  ajayyy#756
@AronHK AronHK mentioned this issue Dec 12, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decouple audio notification from Skip Notice AronHK/SponsorBlock
2 participants
@ajayyy @nerivera