Update lib/AuthorizeNetTD.php #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo doc for time format
|
I don't disagree with the removal of constants at all (I'm definitely in favor), but I want to make it clear that I'm personally not interested in furthering the development of this library. My concern is if Authorize.NET makes some backwards incompatible change to their core web service and thus has to release new a new PHP SDK, it no longer becomes trivial to upgrade this repo with the new SDK. I'm comfortable merging this in as I doubt Authorize.NET will change anytime soon, but it may be worth looking into a more abstracted payment gateway library if you're looking for a nicer interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo doc for time format