Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation. #1

Merged
merged 3 commits into from
Jun 16, 2017
Merged

Fix compilation. #1

merged 3 commits into from
Jun 16, 2017

Conversation

diasbruno
Copy link

No description provided.

@diasbruno
Copy link
Author

This combination will compile correctly. I'll add the Make rules to compile to lib.

@diasbruno diasbruno changed the title use the correct babel presets combination. Fix compilation. Jun 16, 2017
@diasbruno
Copy link
Author

I think this will be enough to get a fix for our latest version.

@fuller fuller merged commit a3e0332 into fuller:master Jun 16, 2017
@fuller fuller mentioned this pull request Jun 16, 2017
Merged
5 tasks
fuller pushed a commit that referenced this pull request Jun 23, 2017
@diasbruno
[fixed] check if the modal content is available when async update... (#1
07a2753 
)

It seems that the using redux, we can get a async update in which can fail
when trying to focus the content of the modal.

This should be a temporary fix since the issue is hard to reproduce,
but safe for other applications.
fuller pushed a commit that referenced this pull request Jun 26, 2017
@diasbruno
[fixed] check if the modal content is available when async update... (#1
95aabda 
)

It seems that the using redux, we can get a async update in which can fail
when trying to focus the content of the modal.

This should be a temporary fix since the issue is hard to reproduce,
but safe for other applications.
fuller pushed a commit that referenced this pull request Jun 27, 2017
@diasbruno
[fixed] check if the modal content is available when async update... (#1
5c1c657 
)

It seems that the using redux, we can get a async update in which can fail
when trying to focus the content of the modal.

This should be a temporary fix since the issue is hard to reproduce,
but safe for other applications.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@diasbruno @fuller