-
Notifications
You must be signed in to change notification settings - Fork 94
Support null database driver #102
Support null database driver #102
Conversation
👍 |
c4c71b6
to
ccb8665
Compare
ccb8665
to
29e1040
Compare
@@ -9,7 +9,7 @@ class Rails < Drivers::Framework::Base | |||
migrate migration_command deploy_environment assets_precompile assets_precompilation_command | |||
envs_in_console | |||
] | |||
packages debian: 'zlib1g-dev', rhel: 'zlib-devel' | |||
packages debian: %w[libxml2-dev tzdata zlib1g-dev], rhel: %w[libxml2-devel tzdata zlib-devel] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajgon This is worth pointing out. In my attempts to create an integration test with a very simple Rails app (no DB even!) I needed these two packages libxml2-dev
and tzdata
because they are core requirements of Rails 4.x. I think it makes sense to add them here because (a) everyone needs them and (b) they are very standard libraries for the servers that people will be building using opsworks_ruby
anyway.
To satisfy your request for integration tests, I learned me up some Chef Kitchen and created the Of course this means that my PRs will need to be merged in order, but ¯_(ツ)_/¯ we were going to have to merge them in some order anyway! |
1 similar comment
…se-adapter Support null database driver
Fixes #98
TODO: