Skip to content
This repository has been archived by the owner on Dec 31, 2022. It is now read-only.

Support null database driver #102

Merged
merged 1 commit into from
Aug 30, 2017

Conversation

nickmarden
Copy link
Contributor

@nickmarden nickmarden commented Aug 25, 2017

Fixes #98

TODO:

  • Write integration tests
  • Add documentation

@coveralls
Copy link

coveralls commented Aug 25, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling c4c71b6 on RapidRiverSoftware:nick/null-database-adapter into 5568f6c on ajgon:master.

@ajgon
Copy link
Owner

ajgon commented Aug 29, 2017

👍
One thing though - can you create an integration test for that?

@coveralls
Copy link

coveralls commented Aug 29, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ccb8665 on RapidRiverSoftware:nick/null-database-adapter into 89ce561 on ajgon:master.

@@ -9,7 +9,7 @@ class Rails < Drivers::Framework::Base
migrate migration_command deploy_environment assets_precompile assets_precompilation_command
envs_in_console
]
packages debian: 'zlib1g-dev', rhel: 'zlib-devel'
packages debian: %w[libxml2-dev tzdata zlib1g-dev], rhel: %w[libxml2-devel tzdata zlib-devel]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajgon This is worth pointing out. In my attempts to create an integration test with a very simple Rails app (no DB even!) I needed these two packages libxml2-dev and tzdata because they are core requirements of Rails 4.x. I think it makes sense to add them here because (a) everyone needs them and (b) they are very standard libraries for the servers that people will be building using opsworks_ruby anyway.

@nickmarden
Copy link
Contributor Author

To satisfy your request for integration tests, I learned me up some Chef Kitchen and created the maximum_override suite. I will now rebase my other pull requests one at a time on top of this PR to add integrations tests for the other "override" behaviors (overriding site configs, overriding logrotate, using passenger as an application loader, etc.) that I have introduced in my PRs.

Of course this means that my PRs will need to be merged in order, but ¯_(ツ)_/¯ we were going to have to merge them in some order anyway!

@coveralls
Copy link

coveralls commented Aug 30, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 29e1040 on RapidRiverSoftware:nick/null-database-adapter into 89ce561 on ajgon:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 29e1040 on RapidRiverSoftware:nick/null-database-adapter into 89ce561 on ajgon:master.

@ajgon ajgon merged commit bb5489b into ajgon:master Aug 30, 2017
@nickmarden nickmarden deleted the nick/null-database-adapter branch August 30, 2017 21:31
dotnofoolin pushed a commit to dotnofoolin/opsworks_ruby that referenced this pull request Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants