This repository has been archived by the owner on Dec 31, 2022. It is now read-only.
Add new webserver_config_params #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajgon
suggested changes
Dec 11, 2019
| @@ -5,7 +5,15 @@ module Appserver | |||
| class Passenger < Drivers::Appserver::Base | |||
| adapter :passenger | |||
| allowed_engines :passenger | |||
| output filter: %i[max_pool_size min_instances mount_point] | |||
| WEBSERVER_CONFIG_PARAMS = %i[ | |||
| max_pool_size min_instances | |||
| deploy['dummy_project']['appserver']['pool_idle_time'] = 300 | ||
| deploy['dummy_project']['appserver']['max_request_queue_size'] = 100 | ||
| deploy['dummy_project']['appserver']['error_document'] = { "503": '503.html', "504": '504.html' } | ||
| deploy['dummy_project']['appserver']['passenger_max_preloader_idle_time'] = 300 |
There was a problem hiding this comment.
Please, add extra tests to it 'creates apache2 passenger config' spec, to test if those params are actually reflected in config.
There was a problem hiding this comment.
Added tests to it 'creates apache2 passenger config' .
…yntax violates the convention
|
Thank you for the review! Added and fixed missing cord. |
dotnofoolin
pushed a commit
to dotnofoolin/opsworks_ruby
that referenced
this pull request
Nov 23, 2021
…n#227) * chore: add new webserver_config_params * style: Fixed failing rubocop lints. * chore: add PassengerMaxPreloaderIdleTime params to webserver_config * fix(appserver): fixed constants and error document values where the syntax violates the convention * test: added webserver_config_params test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there was no item to be set during performance tuning, it was added.