Skip to content

Commit

Permalink
Merge pull request #256 from ajhynes7/try_removing_xfail
Browse files Browse the repository at this point in the history
Remove `xfail` from tests
  • Loading branch information
ajhynes7 committed Mar 7, 2021
2 parents ebb9684 + ad10158 commit 7891d12
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions tests/unit/objects/test_plane.py
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ def test_sum_squares_plane(plane, points, error_expected):
[[0, 0, 0], [1, 0, 0], [0, 1, 0], [0, 0, 1]],
Plane([0.25, 0.25, 0.25], [1, 1, 1]),
),
pytest.param(
(
[
[0, 0, 0],
[0, 0, 1],
Expand All @@ -272,7 +272,6 @@ def test_sum_squares_plane(plane, points, error_expected):
[1, 1, 1],
],
Plane([0.5, 0.5, 0.5], [0, 1, 0]),
marks=pytest.mark.xfail(reason="Fails on Travis CI for unknown reason."),
),
],
)
Expand All @@ -290,15 +289,13 @@ def test_best_fit(points, plane_expected):
[
([[0, 0], [1, 0]], "The points must be 3D."),
([[0, 0], [2, 5]], "The points must be 3D."),
pytest.param(
(
[[0, 0, 0], [1, 1, 1], [2, 2, 2]],
"The points must not be collinear.",
marks=pytest.mark.xfail(reason="Fails on Travis CI for unknown reason."),
),
pytest.param(
(
[[0, 0, 0], [1, 1, 1], [-10, -10, -10]],
"The points must not be collinear.",
marks=pytest.mark.xfail(reason="Fails on Travis CI for unknown reason."),
),
],
)
Expand Down

0 comments on commit 7891d12

Please sign in to comment.