-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for all lifecycle events on iOS and Android #3
base: master
Are you sure you want to change the base?
Conversation
Could you tell me what is the use case of these additional events? Also this will be a breaking change since PR seem to remove the existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this PR should be accepted since it gives an extended detection of the app lifecycle. It solves the issue a have opened: #6. Until the merge, I have to use the package pointing the forked repo of @bartonip.
There are plenty of use cases for catching these additional lifecycle states. For example:
-in a finance application: to prevent exposing any sensitive information),
-a timer based trivia game: to prevent users to send the game to background or app switcher.
Apart from that, yes, even though it is more comprehensive, the new enum naming is different in this PR that causes a breaking change.
Unknown event instead of force unwrap
This PR is now almost 10 months old 🥲 Since I want to make this change non breaking, I will fork this PR and add these events into a different stream and a different factory constructor on the Widget to use these. |
96bdb38
to
29ee7fe
Compare
I've added support for all lifecycle events on iOS and Android and the plugin is sending up the exact lifecycle transition from each platform in case granular control of events by platform is required.