Skip to content

Commit

Permalink
bump minor version
Browse files Browse the repository at this point in the history
  • Loading branch information
@ajjahn
ajjahn committed Jul 11, 2016
1 parent 293bcc9 commit ac64bc8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion metadata.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ajjahn-samba",
"version": "0.4.1",
"version": "0.5.0",
"author": "Adam Jahn",
"summary": "Module for provisioning Samba",
"license": "Apache-2.0",
Expand Down

6 comments on commit ac64bc8

@mbrodala
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a tag for this commit? :-)

@ajjahn
Copy link
Owner Author

@ajjahn ajjahn commented on ac64bc8 Jul 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit isn't pointing to an actual release. It's simply saying "things have changed and the next release will have a more significant version number."

Releasing does the following things: build master -> tag -> push to forge -> bump version -> push to github. As you can see the version number that sits in master will always be the next, yet to be released version.

That said, as soon as I get a chance to run the acceptance tests for all the targeted Operating systems, I'll release it.

@mbrodala
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining. I'm just too used to bumping versions only on release. ;-)

@rendhalver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run the acceptance tests in travis-ci?
I have seen a few blog posts about running beaker tests in travis.
This is a bit old but it seems that it's possible: https://www.camptocamp.com/en/actualite/puppet-acceptance-testing-travis-ci/
From memory they switched to using docker after that article was written so you will probably have to turn off docker so you can run the tests in docker containers.
I am pretty sure I have seen other run their beaker tests in travis so it should be possible.

@ajjahn
Copy link
Owner Author

@ajjahn ajjahn commented on ac64bc8 Jul 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbrodala No problem. The reason I like to bump the version immediately after release is so that one can differentiate between the latest release and upstream.

@rendhalver I didn't know travis could run beaker tests, I'd never really looked into it. That would be ideal. I'll create an issue for it.

@rendhalver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will see if I can help get that working.

Please sign in to comment.