Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poptrox doesn't work with jQuery 3.1.0 #39

Closed
marmistrz opened this issue Aug 1, 2016 · 2 comments
Closed

Poptrox doesn't work with jQuery 3.1.0 #39

marmistrz opened this issue Aug 1, 2016 · 2 comments

Comments

@marmistrz
Copy link

marmistrz commented Aug 1, 2016 •
edited
Loading

After clicking on an image, I get the following errors"

TypeError: a.indexOf is not a function
r.fn.load()
 jquery.min.js:4
e.fn.poptrox/<()
 jquery.poptrox.min.js:2
r.event.dispatch()
 jquery.min.js:3
r.event.add/q.handle()
 jquery.min.js:3
.trigger()
 jquery.min.js:4
.trigger/<()
 jquery.min.js:4
.each()
 jquery.min.js:2
r.prototype.each()
 jquery.min.js:2
.trigger()
 jquery.min.js:4
e.fn.poptrox/</<()
 jquery.poptrox.min.js:2
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.fireWith()
 jquery.min.js:2
gb/i()
 jquery.min.js:3
r.fx.tick()
 jquery.min.js:3
ab()
 jquery.min.js:3
 jquery.min.js:4:18715

And after a while

too much recursion
.camelCase()
 jquery.min.js:2
U.prototype.get()
 jquery.min.js:3
.trigger()
 jquery.min.js:4
.trigger/<()
 jquery.min.js:4
.each()
 jquery.min.js:2
r.prototype.each()
 jquery.min.js:2
.trigger()
 jquery.min.js:4
e.fn.poptrox/</</<()
 jquery.poptrox.min.js:2
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
 jquery.min.js:3
r.speed/e.complete()
 jquery.min.js:3
r.Callbacks/i()
 jquery.min.js:2
r.Callbacks/j.add()
 jquery.min.js:2
gb()
 jquery.min.js:3
.animate/g()
 jquery.min.js:3
.dequeue()
@ChrisPuissant ChrisPuissant mentioned this issue Sep 23, 2016
Open
@flinhong
Copy link

flinhong commented Oct 5, 2016

Just found this answer: http://stackoverflow.com/questions/37738732/jquery-3-0-url-indexof-error

update all

$x.load(function() {});

to

$x.on('load', function() {});

This works for me using jquery-3.1.1.

@ajlkn
Copy link
Owner

ajlkn commented Oct 23, 2016

Yup, what @flinhong said. There's a lot of legacy crap in Poptrox (it's an old plugin), so I'm probably just going to rewrite the entire thing.

@ajlkn ajlkn closed this as completed Oct 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marmistrz @ajlkn @flinhong