Add alternate draw script, fix some bugs #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to help protect the drill bit when drilling. This is a non-optimal solution, since most times while milling we could lift-off at move speed, but I don't want to take time right now to sort out the code enough for that, so I'm just having it use feed speed every time, and relying on it not to take too long, since it's not very far and not that often. This includes a couple of updates to make this not break visualize.py
Previous version of code left out the last mill step. Oops!
Try to draw what the robot will etch out, assume a 45 degree v-bit
I thought this fixed another issue I was seeing, but it seems not to. Ooops
previously it would set all the drill depths to spot-drill depths...
|
Great! Thanks for submitting the new code and bug fixes. |
ajmendez
added a commit
that referenced
this pull request
Sep 10, 2015
Add alternate draw script, fix some bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
out of order and all merged together. If you wanted to be picky about "one pull request per feature set" I could separate them, but...