Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/#1616 better user management #1748

Merged
merged 8 commits into from
Dec 20, 2023

Conversation

manuel-rw
Copy link
Collaborator

image
image
image
image

@manuel-rw manuel-rw added the ✨ Feature A feature you'd like to be added label Dec 17, 2023
@manuel-rw manuel-rw self-assigned this Dec 17, 2023
# Conflicts:
#	src/pages/manage/users/index.tsx
Copy link

github-actions bot commented Dec 17, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 16.17% 4494 / 27791
🔵 Statements 16.17% 4494 / 27791
🔵 Functions 6.68% 29 / 434
🔵 Branches 37.38% 123 / 329
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/Manage/User/change-user-role.modal.tsx 0% 0% 0% 0% 1-60
src/components/Manage/User/Edit/GeneralForm.tsx 0% 0% 0% 0% 1-81
src/components/Manage/User/Edit/ManageUserDanger.tsx 0% 0% 0% 0% 1-83
src/components/Manage/User/Edit/ManageUserRoles.tsx 0% 0% 0% 0% 1-65
src/components/Manage/User/Edit/ManageUserSecurityForm.tsx 0% 0% 0% 0% 1-91
src/pages/manage/users/index.tsx 0% 0% 0% 0% 1-253
src/pages/manage/users/[userId]/edit.tsx 0% 0% 0% 0% 1-90
src/server/api/routers/user.ts 0% 0% 0% 0% 1-403
src/tools/server/translation-namespaces.ts 100% 100% 100% 100%
Generated in workflow #5948

@Meierschlumpf
Copy link
Collaborator

How does it look like in mobile?

Copy link
Collaborator

@SeDemal SeDemal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User's column in the main manage user's table looks bad on mobile, the icon, username and roles stack up. Otherwise mobile layout is nice.

Editing the email, it won't throw an error if the email format is not followed like it does for the account creation.

Deleting a user should bring you back to the manage page after the deletion.
As of now you can still stay on the page and do things (of which none will be saved anyway, but still a bit strange).

Saving a new password doesn't untick the confirm box. (Don't really know if it matters that much).

Edit page (Not the user management page, strictly the edit page) should be available to non admins for their own details.
That way users can update their own passwords and emails.

src/components/Manage/User/Edit/GeneralForm.tsx Outdated Show resolved Hide resolved
src/components/Manage/User/Edit/GeneralForm.tsx Outdated Show resolved Hide resolved
@SeDemal
Copy link
Collaborator

SeDemal commented Dec 19, 2023

Addressed my own comment in this PR #1751 except users self management.

@manuel-rw manuel-rw merged commit 553fa98 into dev Dec 20, 2023
3 checks passed
@manuel-rw manuel-rw deleted the feature/#1616-better-user-management branch December 20, 2023 09:18
truecharts-admin added a commit to truecharts/charts that referenced this pull request Dec 31, 2023
…45f163b by renovate (#16654)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/ajnart/homarr](https://togithub.com/ajnart/homarr) | patch |
`0.14.2` -> `0.14.3` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>ajnart/homarr (ghcr.io/ajnart/homarr)</summary>

### [`v0.14.3`](https://togithub.com/ajnart/homarr/releases/tag/v0.14.3)

[Compare
Source](https://togithub.com/ajnart/homarr/compare/v0.14.2...v0.14.3)

### 🎆🎆 Happy new Year!

Thank you for all your support in 2023 - we really appreciate it.
Homarr has been downloaded almost 4 million times with over 400'000
instances running the latest versions.
Due to the increase in traffic, we have upgraded our website at
https://homarr.dev/ significantly and moved our infrastructure to a
hosting provider.
We are looking forward to see you in 2024!

#### Better user management


![image](https://togithub.com/ajnart/homarr/assets/30572287/5bf6221b-0803-46df-8ae7-9666e6662fe6)

#### Redesigned torrent table

Thanks to [@&#8203;InterN0te](https://togithub.com/InterN0te) , our
torrent widget has received a great upgrade:

![image](https://togithub.com/ajnart/homarr/assets/30572287/1f16c5d9-448f-48f7-948e-9b9f8d75ecb4)

#### Gravatar support

Homarr now integrates seamlessly with Gravatar. Simply upload a profile
picture to Gravatar and you're good to go!


![image](https://togithub.com/ajnart/homarr/assets/30572287/f5cbd6eb-26dd-41e6-8423-39bf4d411873)

#### Updated docker integration

We've added back the Docker integration to your boards.
It's now easier to use than ever.


![image](https://togithub.com/ajnart/homarr/assets/30572287/2308915a-04ac-4504-ad10-24f70eaf9c90)

![image](https://togithub.com/ajnart/homarr/assets/30572287/401db133-2dc5-42af-aef5-cd86ed1ebd33)

#### CLI tool

Did you get locked out? Using our CLI tool, you can reset your password
to recover your Homarr instance:

![image](https://togithub.com/ajnart/homarr/assets/30572287/b8fb30cd-c7e7-4bd3-ab43-d0b5f955197f)

#### What's Changed

- Update acceptableStatusCodes.ts by
[@&#8203;jeffersonraimon](https://togithub.com/jeffersonraimon) in
[ajnart/homarr#1709
- ✨ [#&#8203;1616](https://togithub.com/ajnart/homarr/issues/1616)
Recovery script in Docker container by
[@&#8203;manuel-rw](https://togithub.com/manuel-rw) in
[ajnart/homarr#1726
- 🐛 About page and manage user pages not translated by
[@&#8203;ajnart](https://togithub.com/ajnart) in
[ajnart/homarr#1724
- ✨ Use gravatar with user email by
[@&#8203;Tagaishi](https://togithub.com/Tagaishi) in
[ajnart/homarr#1688
- Switch torrents Table to MantineReactTable with filter/sort function
by [@&#8203;InterN0te](https://togithub.com/InterN0te) in
[ajnart/homarr#1557
- ⚡️ Improve code in manage layout page by
[@&#8203;Tagaishi](https://togithub.com/Tagaishi) in
[ajnart/homarr#1681
- Updated entityStateSchema to handle nullables by
[@&#8203;gfomichev](https://togithub.com/gfomichev) in
[ajnart/homarr#1744
- feature/[#&#8203;1616](https://togithub.com/ajnart/homarr/issues/1616)
better user management by
[@&#8203;manuel-rw](https://togithub.com/manuel-rw) in
[ajnart/homarr#1748
- New Crowdin updates by [@&#8203;ajnart](https://togithub.com/ajnart)
in
[ajnart/homarr#1701
- fix: umlaute in RSS by
[@&#8203;manuel-rw](https://togithub.com/manuel-rw) in
[ajnart/homarr#1755
- New Crowdin updates by [@&#8203;ajnart](https://togithub.com/ajnart)
in
[ajnart/homarr#1761
- ⚡️ Remove location based timezone resolving by
[@&#8203;Tagaishi](https://togithub.com/Tagaishi) in
[ajnart/homarr#1680
- Import to docker form board, Docker button on boards by
[@&#8203;ajnart](https://togithub.com/ajnart) in
[ajnart/homarr#1714
- Update FUNDING.yml by [@&#8203;ajnart](https://togithub.com/ajnart) in
[ajnart/homarr#1768
- 🔧 Configure Stale Action by
[@&#8203;manuel-rw](https://togithub.com/manuel-rw) in
[ajnart/homarr#1752
- 🔧 Configure greetings by
[@&#8203;manuel-rw](https://togithub.com/manuel-rw) in
[ajnart/homarr#1753
- New Crowdin updates by [@&#8203;ajnart](https://togithub.com/ajnart)
in
[ajnart/homarr#1770
- fix: outdated config schema by
[@&#8203;manuel-rw](https://togithub.com/manuel-rw) in
[ajnart/homarr#1769
- chore: increase version in package.json by
[@&#8203;manuel-rw](https://togithub.com/manuel-rw) in
[ajnart/homarr#1771
- Docker import fix by [@&#8203;ajnart](https://togithub.com/ajnart) in
[ajnart/homarr#1773

#### New Contributors

- [@&#8203;jeffersonraimon](https://togithub.com/jeffersonraimon) made
their first contribution in
[ajnart/homarr#1709
- [@&#8203;gfomichev](https://togithub.com/gfomichev) made their first
contribution in
[ajnart/homarr#1744

**Full Changelog**:
ajnart/homarr@v0.14.2...v0.14.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature A feature you'd like to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants