Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make simplistic ping #1789

Closed
wants to merge 2 commits into from
Closed

Make simplistic ping #1789

wants to merge 2 commits into from

Conversation

ajnart
Copy link
Owner

@ajnart ajnart commented Jan 5, 2024

Remove everything in ping and make it so that the ping only fails on ECONNREFUSED or ENOTFOUND

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 16.53% 4597 / 27800
🔵 Statements 16.53% 4597 / 27800
🔵 Functions 6.65% 29 / 436
🔵 Branches 38.08% 123 / 323
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/Dashboard/Modals/EditAppModal/Tabs/NetworkTab/NetworkTab.tsx 0% 0% 0% 0% 1-25
src/components/Dashboard/Tiles/Apps/AppPing.tsx 30.71% 100% 0% 30.71% 14-52, 60-69, 72-76, 86-111, 124-140
src/server/api/routers/app.ts 0% 0% 0% 0% 1-39
Generated in workflow #6054

@manuel-rw manuel-rw mentioned this pull request Jan 14, 2024
Merged
@manuel-rw
Copy link
Collaborator

Superseded by #1819

@manuel-rw manuel-rw closed this Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajnart @manuel-rw