Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option for noreferrer #2048

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Added an option for noreferrer #2048

wants to merge 6 commits into from

Conversation

H3phaist0s
Copy link

@H3phaist0s H3phaist0s commented May 13, 2024

Category

Bugfix / Feature

Overview

Added an option to specify if the referrer should be omitted from the request headers for the external URLs.

Issue Number (if applicable)

Related issue: #1933

Screenshot (if applicable)

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋. Thank you for making your first contribution to Homarr. Please ensure that you've completed all the points in the TODO checklist. We'll review your changes shortly.

Copy link
Collaborator

@SeDemal SeDemal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajnart
Copy link
Owner

ajnart commented May 15, 2024

Actually can you make this default behavior ? (Remove the option and add it by default)
Do you agree @manuel-rw

@H3phaist0s
Copy link
Author

This should be probably be noted as a separate issue but I just noticed that after updating the PR the review status didn't change. You may want to update your repo settings so people can't push code after a review is complete but before the PR is merged.

@Meierschlumpf
Copy link
Collaborator

@H3phaist0s as you've removed the switch you can probably revert also the changes in default.json, add-app.json, shared/app.ts and types/app.ts. As well as removing the check for app.behaviour.noReferrer and just use noreferrer as value for the app tile. At least when I undestand the statement of @ajnart correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants