-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an option for noreferrer #2048
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋. Thank you for making your first contribution to Homarr. Please ensure that you've completed all the points in the TODO checklist. We'll review your changes shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Actually can you make this default behavior ? (Remove the option and add it by default) |
This should be probably be noted as a separate issue but I just noticed that after updating the PR the review status didn't change. You may want to update your repo settings so people can't push code after a review is complete but before the PR is merged. |
@H3phaist0s as you've removed the switch you can probably revert also the changes in |
Category
Overview
Issue Number (if applicable)
Screenshot (if applicable)