Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docker images to match #296

Merged
merged 4 commits into from
Jul 22, 2022
Merged

Conversation

RichyHBM
Copy link
Contributor

Thank you for contributing to Homarr! So that your Pull Request can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category

One of: Feature

Overview

Add a number of high usage docker images to match the type of service to

Issue Number (if applicable)

N/A

New Vars (if applicable)

N/A

Screenshot (if applicable)

N/A

@vercel
Copy link

vercel bot commented Jul 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
homarr-docs ⬜️ Ignored (Inspect) Jul 21, 2022 at 5:50PM (UTC)

@ajnart
Copy link
Owner

ajnart commented Jul 21, 2022

Just a quick comment, did you manually order the imports alphabetically or does your ide do that on purpose ?

I only add dependencies by typing the name and then pressing enter so it auto appends it in the import statement

Other than that great work ! 👍🏼 This should improve matching a lot

@ajnart
Copy link
Owner

ajnart commented Jul 21, 2022

Will merge tomorrow on desktop because you've selected the master branch as target

@RichyHBM
Copy link
Contributor Author

Ahh the alphabetical thing was my habits, happy to change it back if you think it will be an issue?

@ajnart
Copy link
Owner

ajnart commented Jul 22, 2022

Ahh the alphabetical thing was my habits, happy to change it back if you think it will be an issue?

It's not i was just curious if some tools did it for you

@ajnart ajnart changed the base branch from master to dev July 22, 2022 13:17
@ajnart ajnart merged commit f7aa633 into ajnart:dev Jul 22, 2022
jonjon1123 pushed a commit to jonjon1123/homarr that referenced this pull request Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants