Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n translations #357

Merged
merged 11 commits into from
Aug 25, 2022
Merged

Add i18n translations #357

merged 11 commits into from
Aug 25, 2022

Conversation

manuel-rw
Copy link
Collaborator

@manuel-rw manuel-rw commented Aug 22, 2022

Thank you for contributing to Homarr! So that your Pull Request can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category

Feature

Overview

  • Add i18n for translations
  • Add selector for language
  • Add flags for language selector

@vercel
Copy link

vercel bot commented Aug 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
homarr-docs ⬜️ Ignored (Inspect) Aug 25, 2022 at 9:07AM (UTC)

@manuel-rw
Copy link
Collaborator Author

Here's a preview of the current state:

homarr-i18n-update

@manuel-rw
Copy link
Collaborator Author

manuel-rw commented Aug 24, 2022

@ajnart is there something wrong with the ResponsiveLine component? It gives an error that it cannot be used as a JSX component. Deployment from the pipeline is always failing.

@manuel-rw
Copy link
Collaborator Author

There are still two issues, which should be resolved before merging:

  • Even though module names are loaded from the translations, they don't load. Check out the Calendar module: It has a translation for German: "Kalendar". However, it is not being displayed in the module enabler.
  • Translations load (not all, maybe typos?) in the module settings. However, they also don't translate to German - It's probably the same issue like above.

When this is fixed, the Draft attribute can be removed and it would be ready for review.

@manuel-rw manuel-rw mentioned this pull request Aug 24, 2022
@ajnart ajnart marked this pull request as ready for review August 25, 2022 09:40
@ajnart ajnart merged commit d01fd84 into ajnart:dev Aug 25, 2022
@manuel-rw manuel-rw deleted the add-i18n-translations branch August 25, 2022 09:53
jonjon1123 pushed a commit to jonjon1123/homarr that referenced this pull request Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants