Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› Add ipv6 support for url regex #864

Merged
merged 1 commit into from Apr 26, 2023
Merged

Conversation

manuel-rw
Copy link
Collaborator

@manuel-rw manuel-rw commented Apr 26, 2023

πŸ€– Generated by Copilot at 918768a

Summary

πŸ›πŸŒπŸ› οΈ

Fixed app URL validation for IPv6 addresses in EditAppModal. Modified appUrlRegex constant in src/components/Dashboard/Modals/EditAppModal/EditAppModal.tsx to allow square brackets in the domain name.

appUrlRegex changed
Square brackets for IPv6
Winter of bug fix

Walkthrough

  • Allow square brackets in app URL validation to support IPv6 addresses (link)

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
homarr βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 26, 2023 8:28am

@manuel-rw manuel-rw linked an issue Apr 26, 2023 that may be closed by this pull request
4 tasks
@manuel-rw manuel-rw marked this pull request as ready for review April 26, 2023 08:26
@manuel-rw manuel-rw merged commit 678c8d0 into dev Apr 26, 2023
6 checks passed
@manuel-rw manuel-rw deleted the fix/url-regex-ipv6-support branch April 26, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipv6 value is not valid url
1 participant