Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade to @tabler/icons-react #914

Merged
merged 1 commit into from May 16, 2023
Merged

Conversation

ajnart
Copy link
Owner

@ajnart ajnart commented May 15, 2023

🤖 Generated by Copilot at 6f48caf

Summary

🐛🚚🚀

This pull request updates the icon imports and prop types in various components to use the React version of the @tabler/icons package, which fixes a rendering bug and improves compatibility and performance. It also moves the MobileRibbon component to a different file as part of a refactoring process.

The icons were buggy and slow
So we switched to @tabler/icons-react, you know
We also refactored some files
To make the code more agile
And now the app has a better flow

Walkthrough

  • Replace @tabler/icons with @tabler/icons-react to fix icon rendering bug (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Update the type of setIcon and image props from TablerIcon to Icon to match the new import (link, link, link)
  • Move MobileRibbon component from src/components/Dashboard/Mobile/Ribbon/MobileRibbon.tsx to src/components/Config/LoadConfig.tsx to reorganize the components and improve the code structure (link)

@vercel
Copy link

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
homarr ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 8:59am

@ajnart ajnart merged commit f8dcd40 into dev May 16, 2023
6 checks passed
@ajnart ajnart deleted the migrate/tabler-icons-react branch May 16, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant