New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
β¨ Add ad guard home #937
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Next.js Bundle Analysis for homarrThis analysis was generated by the Next.js Bundle Analysis action. π€
|
Page | Size (compressed) |
---|---|
global |
366.14Β KB (π‘ +4.94Β KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Four Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/ |
78.65Β KB (π‘ +3.31Β KB) |
444.79Β KB |
/[slug] |
78.66Β KB (π‘ +3.31Β KB) |
444.8Β KB |
/login |
1.15Β KB (π‘ +70Β B) |
367.29Β KB |
/migrate |
8.14Β KB (π‘ +436Β B) |
374.28Β KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
|
...ard/Modals/EditAppModal/Tabs/IntegrationTab/Components/InputElements/IntegrationSelector.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just annoyed about the new files. I think we already have way more than enough folders and files in the project. Imo all the tools could be in one ts
file
@manuel-rw don't forget to change the status from draft when the PR is ready |
6b19c3c
to
22f7b67
Compare
31bf2c4
to
ee94778
Compare
π€ Generated by Copilot at 2b5a051
Summary
π‘οΈπ§ͺπ
This pull request adds support for AdGuard Home integration in the DNS hole module, which allows users to control and monitor their AdGuard Home apps from the dashboard. It also improves the image rendering of the integration icons and the accuracy of the DNS queries metric. The pull request introduces new files for the AdGuard SDK, Zod schemas, and types, and refactors some existing files to use shared utility functions and classes.
Walkthrough
img
elements withImage
component from@mantine/core
for better styling and performance inIntegrationSelector
component (link, link, link)pihole
image URL inIntegrationSelector
component to match correct file name (link)trimStringEnding
function fromsrc/tools/shared/strings.ts
to trim hostname inPiHoleClient
andAdGuard
classes (link, link, link, link, link)no-await-in-loop
ESLint rule forsrc/pages/api/modules/dns-hole/summary.ts
file, as the loop needs to await API calls for each app (link)Consola.error
message insrc/pages/api/modules/dns-hole/summary.ts
file to use generic term "DNS hole" instead of "PiHole" (link)formatNumber
function call inDnsHoleSummaryWidgetTile
component to use 3 decimal places instead of 0 for DNS queries today metric (link)