Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Fix scrollbar bookmark widget #957

Merged
merged 1 commit into from May 20, 2023
Merged

Conversation

manuel-rw
Copy link
Collaborator

@manuel-rw manuel-rw commented May 20, 2023

🤖 Generated by Copilot at bb3b36e

Summary

🎨🪝🌟

Added spacing for edit mode toolbar in BookmarkWidgetTile component. Used a custom hook to access the edit mode state and reformatted the code.

We're sailing on the web with our bookmark widgets
We need some space to edit, so we add some margins
We use a hook to check the mode, and then we style it
We reformat all the code, to make it nice and tidy

Walkthrough

  • Import the useEditModeStore hook to access the edit mode state (link)
  • Declare the isEditModeEnabled variable using the hook (link)
  • Add the mr property to the Box and ScrollArea components that wrap the bookmark widget layouts (link, link)
  • Reformat the code for readability and consistency (link)

@vercel
Copy link

vercel bot commented May 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
homarr ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2023 4:02pm

@github-actions
Copy link

📦 Next.js Bundle Analysis for homarr

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 366.2 KB (🟡 +5 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 78.65 KB (🟡 +3.31 KB) 444.85 KB
/[slug] 78.66 KB (🟡 +3.32 KB) 444.86 KB
/login 1.15 KB (🟡 +70 B) 367.35 KB
/migrate 8.14 KB (🟡 +436 B) 374.34 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@manuel-rw manuel-rw merged commit 336aff1 into dev May 20, 2023
7 checks passed
@manuel-rw manuel-rw deleted the fix/scrollbar-bookmarks branch May 20, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant