Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConversationalRetrievalChain #29

Closed
audvin opened this issue May 5, 2023 · 6 comments
Closed

ConversationalRetrievalChain #29

audvin opened this issue May 5, 2023 · 6 comments
Labels
awaiting-response feature New feature or request

Comments

@audvin
Copy link

audvin commented May 5, 2023

Would this work together with ConversationalRetrievalChain?

E.g.

qa = ConversationalRetrievalChain(
    retriever=vectorstore.as_retriever(),
    combine_docs_chain=doc_chain,
    question_generator=question_generator,
    return_source_documents=False,
    get_chat_history=get_chat_history,
)

Ref: https://langchain-fanyi.readthedocs.io/en/latest/modules/chains/index_examples/chat_vector_db.html?highlight=ConversationalRetrievalChain#conversationalretrievalchain-with-streaming-to-stdout

@audvin audvin added the feature New feature or request label May 5, 2023
@ajndkr
Copy link
Owner

ajndkr commented May 6, 2023

Hi! @audvin We already have a PR open towards this! #16.

It’s still in progress.

@rogalvil
Copy link
Contributor

rogalvil commented May 6, 2023 via email

@ajndkr
Copy link
Owner

ajndkr commented May 6, 2023

No rush!

@audvin
Copy link
Author

audvin commented May 7, 2023

That's awesome to hear! 🙏

@ajndkr
Copy link
Owner

ajndkr commented May 10, 2023

@audvin streaming response support for ConversationalRetrievalChain has been added in 0.4.4. It should be available via pip soon!

let us know if it works!

@tejeshbhalla
Copy link

@ajndkr if i want to call the streaming handler i get the crux one thing i wanna know if i am not mainting history on the frontend side is there a way to get the whole response after its done streaming to commit it back to the db as history ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-response feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants