Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The service plugin is unusable as advertised #381

Closed
Vampire opened this issue Feb 11, 2023 · 0 comments · Fixed by #382
Closed

The service plugin is unusable as advertised #381

Vampire opened this issue Feb 11, 2023 · 0 comments · Fixed by #382

Comments

@Vampire
Copy link
Contributor

Vampire commented Feb 11, 2023

The docs correctly say that usesService should be called for tasks that use the service.
But this does not work and is not tested.
If you add the call to the compat test, you will see that you get complaints about the provider type.
Even if you don't do it like in the documentation but use the original provider from the extension, you get the same build error.
You have to give the original provider you got from the register call to the usesService method.
But in the extension you only provide an arbitrary provider (actually, a property) that is set using the provider from the register call.
But you have to provide the original provider via the extension and change the readme to advise to use the original provider, not the property of the task class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant