Fixed bug #419 where opening a file without permission would cause th…

…e ChangeCheckerThread to continuously spam lerror log message boxes.

src/ChangeCheckerThread.cpp

@@ -58,7 +58,13 @@ void* ChangeCheckerThread::Entry() {
 
 			// file could be locked by another app
 			// or the remote site could be unavailable
-			if (!modDate.IsValid()) continue;
+			// or we could not have permission to see it
+			// handle this in the event thread
+			if (!modDate.IsValid()) {
+				changedFiles.Add(p->path);
+				modDates.push_back(modDate);
+				continue;
+			}
 
 			// Check if this change have been marked to be skipped
 			if (p->skipDate.IsValid() && modDate == p->skipDate) continue;

src/EditorFrame.cpp

@@ -1110,18 +1110,40 @@ void EditorFrame::OnFilesChanged(wxFilesChangedEvent& event) {
 	const unsigned int count = paths.GetCount();
 	for (unsigned int i = 0; i < count; ++i) {
 		const wxString& path = paths[i];
+		bool close = false;
+
+		wxDateTime modTime = modDates[i];
+		if(!modTime.IsValid()) {
+			int answer = wxMessageBox(wxString::Format(wxT("Unable to read file %s.  Would you like to close it?"), path), wxT("Error"), wxYES_NO);
+			if(answer == wxYES) {
+				close = true;
+			}
+		}
 
 		// Find doc with current path
 		const unsigned int pageCount = m_tabBar->GetPageCount();
-		for (unsigned int p = 0; p < pageCount; ++p) {
+		unsigned int p;
+		for (p = 0; p < pageCount; ++p) {
 			const EditorCtrl* page = GetEditorCtrlFromPage(p);
 			const wxString filePath = page->GetPath();
 			if (path == filePath) {
-				pathsToPages.push_back(p);
-				pageDates.push_back(modDates[i]);
+				if(!close) {
+					pathsToPages.push_back(p);
+					pageDates.push_back(modDates[i]);
+				}
 				break;
 			}
 		}
+
+		if(close && p < pageCount) {	
+			Freeze(); // optimize redrawing
+			DeletePage(p, true);
+
+			// If we deleted last editCtrl, then we have to create a new empty one
+			if (m_tabBar->GetPageCount() == 0) AddTab();
+
+			Thaw(); // optimize redrawing
+		}
 	}
 
 	AskToReloadMulti(pathsToPages, pageDates);