-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VI()
function does not extract correct graphic title
#24
Comments
Looks like the "main" (title) is being extracted from "x[extraArgs[main]]" rather than x[main]. A change in this should solve the issue. |
Is the same or similar solution going to fix axis labels?
From: Sophie Banks <notifications@github.com>
Sent: Wednesday, 17 February 2021 5:31 PM
To: ajrgodfrey/BrailleR <BrailleR@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [ajrgodfrey/BrailleR] `VI()` function does not extract correct graphic title (#24)
Looks like the "main" (title) is being extracted from "x[extraArgs[main]]" rather than x[main]. A change in this should solve the issue.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#24 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADCZKGVNO6ASJYFMBZEX4Y3S7NA63ANCNFSM4QONXBMA>.
|
Yes, should do. I don't know what file the changes need to go in as I've
only looked into the ggplot parts of brailleR.
…On Wed, 17 Feb 2021 at 17:37, Jonathan Godfrey ***@***.***> wrote:
Is the same or similar solution going to fix axis labels?
From: Sophie Banks ***@***.***>
Sent: Wednesday, 17 February 2021 5:31 PM
To: ajrgodfrey/BrailleR ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [ajrgodfrey/BrailleR] `VI()` function does not extract
correct graphic title (#24)
Looks like the "main" (title) is being extracted from "x[extraArgs[main]]"
rather than x[main]. A change in this should solve the issue.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<
#24 (comment)>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/ADCZKGVNO6ASJYFMBZEX4Y3S7NA63ANCNFSM4QONXBMA>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOWHJFIXLFSYCVZGNFBRPZDS7NBXBANCNFSM4QONXBMA>
.
|
1jamesthompson1
added a commit
to 1jamesthompson1/BrailleR
that referenced
this issue
Nov 28, 2022
Fixing issues with base r plots with VI not picking up on the correct title.
Closed
1jamesthompson1
added a commit
to 1jamesthompson1/BrailleR
that referenced
this issue
Nov 28, 2022
Fixing base r plot titles so that they reflect correctly what is seen.
ajrgodfrey
added a commit
that referenced
this issue
Dec 6, 2022
…r-plot-titles resolves #24 fix base r plot titles in VI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When generating text description for R graphics via
BrailleR::VI()
function, user-defined title is not extracted. It would be better for us to fix this.Reproducible Example
Created on 2020-08-28 by the reprex package (v0.3.0.9001)
Session info
The text was updated successfully, but these errors were encountered: