var idea #1
var idea #1
Conversation
|
Thank you very much! The only problem I have with your pull request is that it does add more bytes than I would like. Thankfully, there is a "PostCSS" plugin that can transform what you wrote directly to what I have, by replacing each variable with the correct value. I will probably merge your PR in once I have this PostCSS stuff figured out. |
| --accent-color: #234567; | ||
| --link-color: gold; | ||
| --border-color: green; | ||
| --primary-button-bg: gold; |
There was a problem hiding this comment.
Hey, could you change the "gold" back to the original hexadecimal value of #FA0? #FA0 saves one extra byte with gzip for some reason. If you want, you could add a comment after the "#FA0" saying "gold".
Other than that, I think that this is a great idea and will merge as soon as I figure out the PostCSS stuff!
|
Just finished getting all Gulp and PostCSS set up for the first time. I'll try and do a merge here |
|
I did merge this in, but then I changed some significant parts of it. I liked the idea, so I kept most of the variables, and I renamed a few to make more sense to me. I don't plan on adding secondary buttons or more components anytime soon. |
|
awesome! i’m glad you liked the idea! doing a find to replace seems like it might be a problem later if you ever update the repo. this way someone could define their own ‘primitive’ vars that’s sweet! keep up the great work! |
|
Yeah, good point. Hope you enjoy using it! |
just an idea... thought i'd throw it out there... love what you've done here! the simplicity is great!
Not sure how much this adds but it would be nice to have some easy overrides... like i said. just a thought.