Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid cell with "6 col" takes more then half of the width if content is large #25

Closed
ractive opened this issue May 15, 2020 · 4 comments
Closed

Comments

@ractive
Copy link

ractive commented May 15, 2020

Hi there

If not defining the column width with two columns or using "6 col", a cell with some larger content will take as much space as it needs. Other column widths than 6 work as expected.

See an example here;
https://www.w3schools.com/code/tryit.asp?filename=GETCRXX18RSO

@ajusa
Copy link
Owner

ajusa commented May 16, 2020

Wow uh... that's a bug. This is probably due to the way tables are used for the grid. I'll try moving the grid system to flexbox (seeing as it has a lot more support now) and that should fix the issue. I'll update and close the issue once I have fixed it.

@ractive
Copy link
Author

ractive commented May 16, 2020

Thanks. Keep up the good work. lit offers everything I need from a CSS framework... :-)

@ajusa
Copy link
Owner

ajusa commented May 21, 2020

This is now fixed with 6336fc1. Closing the issue for now.
I'm planning on working on this project more soon, so once other changes are done I'll make a release. Until a release happens, the example will be broken since it links to the latest release. If you want to test it (I did verify that your example works), you can download dist/lit.css in the repository.

@ajusa ajusa closed this as completed May 21, 2020
@ractive
Copy link
Author

ractive commented May 23, 2020

It works, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants