Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update fast-json-patch for security #227

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jan 8, 2023

Resolves #225
Resolves #229
Resolves GHSA-8gh8-hqwg-xf34

@epoberezkin let me know if you need any help with getting this landed it'll also want #218 or similar to fix CI, and it seems like there's a few dev dependencies that could be cleaned up which I'm happy to do after both of these have been landed. - I've ended up just pulling in the TypeScript changes required to get CI green.

Yogu added a commit to AEB-labs/cruddl that referenced this pull request Jan 16, 2023
Cannot fix the ajv-cli vulnerability currently, see
- ajv-validator/ajv-cli#227
- Starcounter-Jack/JSON-Patch#308
Yogu added a commit to AEB-labs/cruddl that referenced this pull request Jan 16, 2023
Cannot fix the ajv-cli vulnerability currently, see
- ajv-validator/ajv-cli#227
- Starcounter-Jack/JSON-Patch#308
Yogu added a commit to AEB-labs/cruddl that referenced this pull request Jan 18, 2023
Cannot fix the ajv-cli vulnerability currently, see
- ajv-validator/ajv-cli#227
- Starcounter-Jack/JSON-Patch#308
@G-Rath
Copy link
Contributor Author

G-Rath commented Feb 15, 2023

@epoberezkin friendly bump :)

@bodograumann
Copy link

To fix the build failures you need to pin typescript to ~4.1.2 e.g. @G-Rath

I also think package-lock.json should be commited and the pipeline should use npm ci, but that might be out-of-scope here. Fixing the security issue is more pressing.

@G-Rath
Copy link
Contributor Author

G-Rath commented Apr 12, 2023

@bodograumann fixing ci is out of scope here too - there's already #218 open for that

@G-Rath
Copy link
Contributor Author

G-Rath commented May 16, 2023

@epoberezkin I've cherry-picked the TypeScript changes done by @thomastoye over in #218 so now CI is passing, and this should be good to land as-is

@benriemer
Copy link

Any updates? Why it is not merged?

"module_name": "fast-json-patch"
"severity": "high"
"github_advisory_id": "GHSA-8gh8-hqwg-xf34"

Vulnerable advisories are:
GHSA-8gh8-hqwg-xf34

@G-Rath
Copy link
Contributor Author

G-Rath commented Jul 11, 2023

@epoberezkin could we get this landed and released?

@iebold
Copy link

iebold commented Aug 7, 2023

@epoberezkin could we get this landed and released?

We have to contemplate the idea that a project with little to no updates that has been ignoring for the past half year a tiny patch fixing a security issue may be in fact an abandoned project. 😔

@G-Rath
Copy link
Contributor Author

G-Rath commented Oct 1, 2023

@epoberezkin it would be good if we could get this reviewed and released :)

@jpcano-intellegens
Copy link

@G-Rath Thank you for creating this PR. Let's see if this can be reviewed and merged.

@bodograumann
Copy link

This project seems utterly unmaintained. We should think about creating a fork...

@G-Rath
Copy link
Contributor Author

G-Rath commented Jan 17, 2024

@epoberezkin reminder about this - I'm also happy to help with the general maintenance of this cli if you like.

@hexmode
Copy link

hexmode commented Mar 28, 2024

I just posted to twitter for the first time in forever to hopefully get @epoberezkin's attention. He's obviously proud of his work since his profile there says "Created Ajv #JSON validator used by millions of JS apps."

Maybe @ChALkeR can merge, though?

@mrl5
Copy link

mrl5 commented May 17, 2024

until this is not merged you can use this workaround:

diff --git a/package.json b/package.json
index 2dfa265..1efb2ff 100644
--- a/package.json
+++ b/package.json
@@ -8,5 +8,9 @@
   "description": "",
   "dependencies": {
     "ajv-cli": "^5.0.0"
+  },
+  "overrides": {
+    "fast-json-patch": "3.1.1"
   }
+
 }

ref https://docs.npmjs.com/cli/v10/configuring-npm/package-json#overrides

@josundt
Copy link

josundt commented Aug 1, 2024

@epoberezkin Please fix?

While the ajv package properly maintained with new releases from time to time, I find it sad that its CLI seems abandoned - even security vulnerabilities are not longer mitigated.

Remarks: The ajv package generates and evaluates JavaScript code at runtime.
This is - or should be - a security concern for most modern JavaScript-based software.

To utilize the great features of ajv in secure, production-ready LOB software, the CLI is required to generate code at compile time instead of evaluating at runtime. And security vulnerabilities in 3rd party packages are not acceptable here.

Please fix this security vulnerability soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
8 participants