Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #53 Add typescript definitions #106

Merged
merged 2 commits into from Apr 16, 2020
Merged

Fix #53 Add typescript definitions #106

merged 2 commits into from Apr 16, 2020

Conversation

sonallux
Copy link
Contributor

@sonallux sonallux commented Nov 1, 2019

This pull request adds a typescript definitions file ajv-keywords.d.ts and therefore fixes #53.

@coveralls
Copy link

coveralls commented Nov 1, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling a362cc8 on jsone-studios:typings into f8ca6bf on epoberezkin:master.

@sonallux
Copy link
Contributor Author

@epoberezkin friendly ping.

As the main ajv package provides its own TypeScript declarations out of the box, it would be cool to do the same for ajv-keywords.

ajv-keywords.d.ts Outdated Show resolved Hide resolved
@epoberezkin epoberezkin merged commit dbf2884 into ajv-validator:master Apr 16, 2020
@epoberezkin
Copy link
Member

merging it, it would be good to add TS tests in the same way as in ajv to avoid any syntax errors or typos

@sonallux sonallux deleted the typings branch April 16, 2020 15:55
@Marsup
Copy link

Marsup commented Jun 10, 2020

Hello 👋 Would you have an estimated timeline for this to be released? Is it waiting for something else we can help with?

@epoberezkin
Copy link
Member

epoberezkin commented Jun 13, 2020

Thanks for the reminder :) Will do it over the weekend.

@epoberezkin
Copy link
Member

v3.5.0 is released now

mercutiodesign pushed a commit to mercutiodesign/ajv-keywords that referenced this pull request Jul 23, 2020
epoberezkin added a commit that referenced this pull request Jul 27, 2020
Fix #106: add ts definitions to published package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Typescript Definitions
5 participants